Correctly mount file mount points in Overlay2Filesystem #858
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JSCU-CNI
force-pushed
the
fix/overlay-mount-files
branch
from
e58fa0f
to
c0c9dfa
Compare
|
Could you add a unit test? 😄 |
Added in f66885a |
JSCU-CNI
force-pushed
the
fix/overlay-mount-files
branch
from
f66885a
to
4e38b7e
Compare
Schamper
previously approved these changes
Sep 20, 2024
Schamper
previously approved these changes
Sep 23, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #858 +/- ##
==========================================
+ Coverage 76.16% 76.19% +0.02%
==========================================
Files 310 310
Lines 26688 26691 +3
==========================================
+ Hits 20328 20338 +10
+ Misses 6360 6353 -7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Schamper
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #856.